On Fri, 28 May 2004, Martin Diehl wrote: > Correct. I was just trying to imagine what might happen in case of > unexpected behavior. I'm by no means objecting your patch - it's just it > might be the current interpretation could be the best working which was > found so far due to such issues. I just think if all devices would behave > according to the specs the debounce approach would have worked in the > first place and we could drop the longer timeout completely. Something > must be different in real life therefore.
While I don't know what happened during the early testing and development, it's easy to imagine that looking at connect-status-changed alone was insufficient, so the debounce routine was changed to look at connect-status. I'm merely pointing out that it would be better still to look at both. > Ok, you are right, we won't entirely miss the connect change. I still > think when we assume 100ms stable_time this might be too early in some > pathological cases (say fast disconnect-connect cycle after about 80 ms > racing with clear_port_feature) but I believe these will be handled by the > timeout then. The 100ms stable_time may very well be too short for some buggy devices or faulty cable connectors, but I don't think there are any algorithmical problems of the sort you're worried about. If such problems do exist, they will affect the current code at least as badly as the patched code. > Note, I was just trying to explain what I remember about the long history > of this stuff - personally I don't care much since I'll always get my > devices enumerated ;-) But if your patch worked as well as the existing > code or even better, it'd obviously be good to have it applied. The only way to really know is to try it out! If it works okay with my equipment, I'll send it to Greg KH as an official patch submission. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
