On Fri, 4 Jun 2004 16:23:19 +0200
Harald Welte <[EMAIL PROTECTED]> wrote:

> +     dev = (struct usb_device *)(file->private_data);
> +     
> +     temp_urb1=dev->USBMon_data->USBMon_urb_ll_buffered;
> +
> +     wmb(); 
> +
> +     dev->USBMon_data->USBMon_urb_ll_buffered=NULL;

You need more semaphores and less monkeying with barriers.

> @@ -2105,6 +2113,7 @@
>       usb_dec_dev_use (usb_dev);
>       urb->dev = NULL;
>       if (urb->complete)
> +             USBMon_urb_pre_completion(urb);/*USBMon*/
>               urb->complete (urb);
>       return 0;

What do you think the above does? No, really?

Something has to be said about the atrocious styling as well.

-- Pete


-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
>From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to