-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Fri, Jun 04, 2004 at 07:45:48AM -0700, Pete Zaitcev wrote: > On Fri, 4 Jun 2004 16:23:19 +0200 > Harald Welte <[EMAIL PROTECTED]> wrote: > > > + dev = (struct usb_device *)(file->private_data); > > + > > + temp_urb1=dev->USBMon_data->USBMon_urb_ll_buffered; > > + > > + wmb(); > > + > > + dev->USBMon_data->USBMon_urb_ll_buffered=NULL; > > You need more semaphores and less monkeying with barriers.
This is not my code, I just merged Dave Hardings 2.4.4 patch with a more recent 2.4.x kernel. I don't intend to become the maintainer of USBMon ;) > > @@ -2105,6 +2113,7 @@ > > usb_dec_dev_use (usb_dev); > > urb->dev = NULL; > > if (urb->complete) > > + USBMon_urb_pre_completion(urb);/*USBMon*/ > > urb->complete (urb); > > return 0; > > What do you think the above does? No, really? erm, sorry once again... bug was already present in the original code to be found at http://www.linux-usb.org/USBMon/. I will fix it in my local tree, though. > Something has to be said about the atrocious styling as well. yes, I dislike it, too. But as I'm not the original author and just touched somebody else's code - I don't think I should change the overall CodingStyle if I want that patch to get accepted by Dave Harding. > -- Pete To be frank, I'm not sure whether I agree with the overall architecture of USBMon, let aside it's coding style. But AFAIK it is the only freely available usb sniffer available for Linux, and that's why I'm using it. Thanks for your comments, - -- - - Harald Welte <[EMAIL PROTECTED]> http://www.gnumonks.org/ ============================================================================ Programming is like sex: One mistake and you have to support it your lifetime -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAwJ5VXaXGVTD0i/8RAgzZAJ9zDPCNdvaq9UKDp+DelBJOKUIQagCeLEel mV9NgGEdAHlShZtHSQbkI2s= =/Sou -----END PGP SIGNATURE----- ------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X. >From Windows to Linux, servers to mobile, InstallShield X is the one installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
