Use list_for_each() where applicable
- for (list = ymf_devs.next; list != &ymf_devs; list = list->next) {
+ list_for_each(list, &ymf_devs) {
pure cosmetic change, defined as a preprocessor macro in:
include/linux/list.h
patch is against 2.6.7-bk20, please tell if you need against newer.
From: Domen Puncer <[EMAIL PROTECTED]>
Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]>
---
linux-2.6.7-bk20-max/drivers/usb/class/audio.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff -puN drivers/usb/class/audio.c~list_for_each-usb-audio drivers/usb/class/audio.c
--- linux-2.6.7-bk20/drivers/usb/class/audio.c~list_for_each-usb-audio 2004-07-11
14:41:32.000000000 +0200
+++ linux-2.6.7-bk20-max/drivers/usb/class/audio.c 2004-07-11 14:41:32.000000000
+0200
@@ -1954,9 +1954,9 @@ static int usb_audio_open_mixdev(struct
struct usb_audio_state *s;
down(&open_sem);
- for (devs = audiodevs.next; devs != &audiodevs; devs = devs->next) {
+ list_for_each(devs, &audiodevs) {
s = list_entry(devs, struct usb_audio_state, audiodev);
- for (mdevs = s->mixerlist.next; mdevs != &s->mixerlist; mdevs =
mdevs->next) {
+ list_for_each(mdevs, &s->mixerlist) {
ms = list_entry(mdevs, struct usb_mixerdev, list);
if (ms->dev_mixer == minor)
goto mixer_found;
@@ -2644,9 +2644,9 @@ static int usb_audio_open(struct inode *
for (;;) {
down(&open_sem);
- for (devs = audiodevs.next; devs != &audiodevs; devs = devs->next) {
+ list_for_each(devs, &audiodevs) {
s = list_entry(devs, struct usb_audio_state, audiodev);
- for (adevs = s->audiolist.next; adevs != &s->audiolist; adevs
= adevs->next) {
+ list_for_each(adevs, &s->audiolist) {
as = list_entry(adevs, struct usb_audiodev, list);
if (!((as->dev_audio ^ minor) & ~0xf))
goto device_found;
@@ -3835,7 +3835,7 @@ static void usb_audio_disconnect(struct
usb_set_intfdata (intf, NULL);
/* deregister all audio and mixer devices, so no new processes can open this
device */
- for(list = s->audiolist.next; list != &s->audiolist; list = list->next) {
+ list_for_each(list, &s->audiolist) {
as = list_entry(list, struct usb_audiodev, list);
usbin_disc(as);
usbout_disc(as);
@@ -3847,7 +3847,7 @@ static void usb_audio_disconnect(struct
}
as->dev_audio = -1;
}
- for(list = s->mixerlist.next; list != &s->mixerlist; list = list->next) {
+ list_for_each(list, &s->mixerlist) {
ms = list_entry(list, struct usb_mixerdev, list);
if (ms->dev_mixer >= 0) {
unregister_sound_mixer(ms->dev_mixer);
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel