On Tue, Aug 24, 2004 at 01:41:51PM -0700, Pete Zaitcev wrote:
> On Tue, 24 Aug 2004 21:10:38 +0200
> Oliver Neukum <[EMAIL PROTECTED]> wrote:
>
> > Am Dienstag, 24. August 2004 20:33 schrieb Pete Zaitcev:
> > > +???????sc->work_timer.expires = jiffies + UB_URB_TIMEOUT;
> > > +???????add_timer(&sc->work_timer);
> > > +
> > > ????????if ((rc = usb_submit_urb(&sc->work_urb, GFP_ATOMIC)) != 0) {
> >
> > You're doing it the wrong way round.
> > You can not know how long after the timer is added the URB will
> > really go on the wire. You need the add the timer after you've
> > submitted the URB.
>
> Not a bad idea, although the reasoning is obviously faulty,
> as there's no difference in behaviour (see that GFP_ATOMIC?)
> I'll change it to save code.
Care to send your next patch relative to your previous one, as I've
already applied it? :)
thanks,
greg k-h
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
