On Thu, 16 Sep 2004, Alexander Stohr wrote: > MAybe that patch is really really unneccssary, but read on!
On Thu, 16 Sep 2004, Greg KH wrote: > I'll let Alan Stern determine if your patch is ok or not. I think the patch really is unnecessary. If you don't have the ub driver loaded, does usb-storage handle the card reader okay without the extra unusual_devs entry? If it does, then the entry isn't needed. (And most particularly, the FIX_INQUIRY part of the entry isn't needed. Flags like that shouldn't be added for no reason at all -- they are intended purely as workarounds for certain device bugs and they degrade the behavior of non-buggy devices.) I get the feeling that the real problem you want to solve is how to select which driver, ub or usb-storage, will bind to a particular device when both are loaded. Adding an unusual_devs entry is at best a very klugey way of handling this. Maybe the kernel needs better mechanisms for allowing users to make policy choices of this sort -- but for now I can't recommend your approach. What about other users who _do_ want their card readers managed by ub? For now, if you don't want to use the ub driver, my advice is simply not to load it into your kernel. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
