On Tue, 28 Sep 2004 12:18:12 -0400 (EDT) Sam King <[EMAIL PROTECTED]> wrote:
> There is a similar problem with serial_throttle. When the tty buffer > fills, it calls serial_throttle to notify the low level driver of the > condition. This can happen from an interrupt handler (as is the case > with the edgeport usb serial converter io_ti.c and uhci.c host > controller), so I augmented the post_helper kernel task to handle > serial_throttle calls also. OK, you win this time, Sam. I looked closer at io_ti and io_edgeport and I do not require you to fix io_ti anymore. Essentially fixing io_ti would require adding exactly the same queueing into it as port_helper provides already, only driven by interrupts and not a process. Then you'd want to pay attention to IS_XOFF and very quickly the whole thing turns into io_edgeport. Which bears asking, why in the world io_ti exists at all? Is it yet another keyspan_pda type of thing? But before I recommend your patch to Greg, I'd like you to clean it up a little. First, please use existing spacing. I'm not kidding. Second, make sure that usb_serial_post_job stays below 128 bytes in size. Move the type down a line, where it uses less space on 64-bitters. -- Pete ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
