On Tue, 28 Sep 2004 17:05:56 -0400 (EDT) Sam King <[EMAIL PROTECTED]> wrote:
> Done. I also took 8 bytes off of the POST_BSIZE to account for the > extra int (assuming int's are 8 bytes on 64 bit CPUs). No, int is always 4 bytes. The patch is good enough, but keep in mind some things. > --- drivers/usb/serial/usbserial.orig 2004-09-28 10:21:54.000000000 -0400 > +++ drivers/usb/serial/usbserial.c 2004-09-28 16:40:31.000000000 -0400 This is wrong. You ought to generate patches with: diff -ur linux-base linux-work This way the patch can be applied with -p1 > + BUG(); > + } > up(&port->sem); > - > + > spin_lock_irqsave(&post_lock, flags); A replacement of one empty line with another empty line is fishy. Either your diff is toast, or your editor adds trailing space and THEN your mailer strips it. It's a pure luck that your patch is still usable. -- Pete ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
