Greg:
This is all your fault! :-)
The patch below fixes the problem in which the UHCI driver doesn't
properly check the return code from pci_register_driver().
Alan Stern
On Fri, 1 Oct 2004, Andrew Morton wrote:
> Greg's latest tree, on x86_64:
>
> Badness in remove_proc_entry at fs/proc/generic.c:688
>
> Call Trace:<ffffffff8019cfb6>{remove_proc_entry+391}
> <ffffffff805a981f>{uhci_hcd_init+224}
> <ffffffff8010c26d>{init+475} <ffffffff8010ff17>{child_rip+8}
> <ffffffff8010c092>{init+0} <ffffffff8010ff0f>{child_rip+0}
>
>
> WARN_ON(de->subdir);
>
> which is a bit weird. How did driver/uhci get itself a subdirectory?
>
> Maybe it already existed, and uhci_hcd_init() tried to delete it anwyay?
On Sat, 2 Oct 2004, Reuben Farrelly wrote:
> slab error in kmem_cache_destroy(): cache `uhci_urb_priv': Can't free
> all objects
> [<c0104ddc>] dump_stack+0x17/0x19
> [<c013dfd5>] kmem_cache_destroy+0xea/0x15b
> [<c03e17eb>] uhci_hcd_init+0xc8/0xff
> [<c03ca89f>] do_initcalls+0x56/0xb3
> [<c01004f5>] init+0x81/0x189
> [<c01022f1>] kernel_thread_helper+0x5/0xb
> drivers/usb/host/uhci-hcd.c: not all urb_priv's were freed!
> Badness in remove_proc_entry at fs/proc/generic.c:688
> [<c0104ddc>] dump_stack+0x17/0x19
> [<c017c196>] remove_proc_entry+0x129/0x133
> [<c03e1810>] uhci_hcd_init+0xed/0xff
> [<c03ca89f>] do_initcalls+0x56/0xb3
> [<c01004f5>] init+0x81/0x189
> [<c01022f1>] kernel_thread_helper+0x5/0xb
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
===== drivers/usb/host/uhci-hcd.c 1.134 vs edited =====
--- 1.134/drivers/usb/host/uhci-hcd.c 2004-09-30 13:58:40 -04:00
+++ edited/drivers/usb/host/uhci-hcd.c 2004-10-04 10:37:21 -04:00
@@ -2412,7 +2412,7 @@
goto up_failed;
retval = pci_register_driver(&uhci_pci_driver);
- if (retval)
+ if (retval < 0)
goto init_failed;
return 0;
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
