On Tue, Oct 19, 2004 at 03:33:52PM -0700, David Brownell wrote: > On Tuesday 19 October 2004 2:14 pm, Ben Dooks wrote: > > > If you're up for it, I'd rather see a generic hook for > > > turning port N power on/off ... just hang a method in > > > the "struct ohci_hcd", and when it's there ohci-hub.c > > > would call it. It's not just S3C2410 boards needing > > > custom power switching (and overcurrent) handlers! > > > > Should we do something per-port, or for the whole root > > hub? > > Per-port. Ganged switches can use per-port calls. > > > > Would it be easier to make a patch w/o the extra > > power switching code, or to wait until we have sorted > > out the power/oc control? > > It'd be a bit nicer to have two separate patches, > submitted at about the same time. Unless this > HC can be used somehow without the power > switching support!
I was giving this some more thought, and would it be better to do an new file with an helper functions to allow an ohci implementation to override hc_driver.hub_status_data and hc_driver.hub_control? I'd be happy with this way, as it would be less intrusive into the usb hub code, and (iicc) should be as good as changing the hub code itself. -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
