On Thu, 28 Oct 2004, David Brownell wrote: > I think you probably have combined several different patches > here. And one of them would seem to be that patch to make > allocating the usb_bus work more like alloc_etherdev (so that > usbcore can free it.)
Actually no. Although working on this certainly is what led me to that. The patch you saw still has the low-level drivers freeing the memory. I intend to split it up into multiple patches, but the split won't be on functional grounds. It will just be based on the source arrangement (like: everything in usb/core, everything in usb/host, and everything in usb/gadget). > The "init1" then "init2" style bothers me. But then, so > does the current "reset" then "start" style. The reset() > stuff is the same logic that's now cloned (ugh!) over > with the pci quirks. The names will be altered. init1 will become something more like usb_init_hcd. uninit1 will become something more like usb_put_hcd. init2 will become something more like usb_register_hcd. Those names aren't perfect because there's no get to match the put (the hcd doesn't need to be reference counted because its embedded usb_bus already is) and init includes memory allocation (I don't see any point in a separate usb_alloc_hcd). For now I'll leave the struct usb_hcd as the first member of the larger driver-specific structures. Changing over to make the the driver-specific part an extra add-on to the usb_hcd part (à la struct Scsi_Host) will involve a fair number of changes to the HC drivers themselves. Occurrences of things like "ohci->hcd" would all have to be replaced. That can come later. Alan Stern ------------------------------------------------------- This Newsletter Sponsored by: Macrovision For reliable Linux application installations, use the industry's leading setup authoring tool, InstallShield X. Learn more and evaluate today. http://clk.atdmt.com/MSI/go/ins0030000001msi/direct/01/ _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
