On Wed, 3 Nov 2004, Greg KH wrote: > Applied, thanks. > > But please fix this up soon, I really don't like this restriction.
I worked out a series of patches over the weekend, but they conflict in several spots with these patches from David. What would you like me to do? On Sun, 7 Nov 2004, David Brownell wrote: > Hi, > > Following this will be four patches. These four patches, all curiously > about the same size, have been tested: > > - with and without CONFIG_USB_SUSPEND > - using S1/standby and the default STD "shutdown" support > - with and without usb devices connected during suspend/resume > - on two different implementations of EHCI and OHCI > - with both EHCI and OHCI loaded, or only one > - for OHCI, controllers both with and without PCI PM support > - for EHCI, controllers both with and without power switching. > - with BIOS drivers for USB keyboards/mice disabled > > And they all worked, which is a milestone! Though I suspect at a few > of the 2^7 combinations there could still stand more work, and there are > other things that need attention too. Some devices may misbehave; most > USB drivers don't have suspend/resume support; the other STD modes need > testing; USB wakeup through ACPI is about ready to try; and so on. > > I'm thinking that these should all get merged. In particular, there > have been some significant problems recently with OHCI recently, and > these fix them for me; 2.6.10 shouldn't ship with those problems. > > Comments? Although this may not be the best time for it, I would like to see all those USB_STATE_... things for host controllers turn into HCD_STATE_... It's not a good idea to rely on the power.power_state field for the interface devices. In fact, is there really any point in allowing an interface to be suspended without suspending the entire USB device? This seems especially problematic when a driver owns several interfaces on the same device. I suggest the code be restructured so that the bus routines basically ignore suspend/resume calls for interface devices. Then the interfaces will always be in the same state as the physical devices. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
