Joop Zonnet wrote:
Hi list,
I'd like to know what to do next. Can anyone tell me what I did wrong,
please? How should I go about suggesting a patch, a change etc. etc?
wkr,
Gerke
Hi,
I can't help you with testing (no such device), but I'm looking
at your file. I have some comments on it, and then I'll try
to help you on how to make a patch file from it.
1. Don't change struct { ... } ati_remote_tbl
to a typedef. In general, Linux doesn't like or use
typedefs for structures. It hides too much.
Leave a struct as a struct.
2. why did you delete the line(s):
set_current_state(TASK_INTERRUPTIBLE);
before calling schedule_timeout() ?
3. I'm not sure about the changes from usb_kill_urb() to
usb_unlink_urb() (since I haven't been keeping up with the
USB kernel API very well). Maybe someone else can comment
on those.
4. The key conversion handling looks reasonable to me.
OK, to make a patch so that you can post it here:
Do this in a current kernel tree (like linux-2.6.10-rc2):
a. in drivers/usb/input, rename (old) ati_remote.c to
ati_remote.c.221
b. copy your ati_remote.c into drivers/usb/input/
c. cd ../../../.. (i.e., to one level above the
kernel tree)
d. (one command line:)
diff -Naurp linux-2.6.10-rc2/drivers/usb/input/ati_remote.c.221
linux-2.6.10-rc2/drivers/usb/input/ati_remote.c >
ati_remote_222.patch
e. Send an email to [EMAIL PROTECTED] with Subject:
that contains: [PATCH] ati_remote: add Medion RF remote control
(e.g.)
In the body of the email, put a short description of your
patch, diffstat of it (optional but preferred),
Signed-off-by: your name <email address>
and the patch file (inline in the email [text/plain attachment
if you must]). Make sure that your email client does not
mangle/destroy whitespace in your patch.
Here are some very useful references that you should check out:
linux-2.6.x/Documentation/SubmittingPatches
linux-2.6.x/Documentation/SubmittingDrivers
linux-2.6.x/Documentation/CodingStyle
http://linux.yyz.us/patch-format.html
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Joop Zonnet wrote:
Hi list,
some time ago I got myself a computer. Together with that computer I
got a Medion RF remote control.
With lsusb I found that the USB device was the same as the one that
was supported by the ati_remote kernel module, only the sub-id was
differend and later I found the keymap to be different as well.
I mailed to the man who last worked on the driver according to the
source and worked out that there was someone that created a new key
map for my device but that that person did not integrate that new
key-map with the driver. So I had a go at it. In my version it
determines the keymap to use at plug-in time on a per device base.
I was working with the Kernel that came with my disto (Mandrake).
uname -a gives me:
Linux gerkek2.thuis99.org 2.6.8.1-12mdksmp #1 SMP Fri Oct 1
11:24:45 CEST 2004 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz unknown
GNU/Linux
I'm not sure how to go about creating a patch-file or how to go about
getting others to test my changes. I only have one remote control (The
Menion one ;-) ) and would like others to test my changes. I'd be
happy to send the new version of the ati_remote.c file or any other
format if the requester is kind enought to tell me how to get it (diff
or patch or what ever)
--
~Randy
-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
