On Wed, 2004-12-22 at 15:00 +0100, Duncan Sands wrote: > Hi Roman, can you please check that this patch also fixes the debugging > problem > you were presumably seeing.
Yes. Now uncommenting the appropriate define I get the right debugging level. One nitpick: > +#ifdef VERBOSE_DEBUG > +static int udsl_print_packet(const unsigned char *data, int len); > +#define PACKETDEBUG(arg...) udsl_print_packet (arg) These two lines ... > +#define vdbg(arg...) dbg (arg) > +#else > +#define PACKETDEBUG(arg...) ... and this one should better go to usb_atm.c, where PACKETDEBUG is used and udsl_print_packet() is defined. Otherwise with VERBOSE_DEBUG defined I get drivers/usb/atm/usb_atm.h:49: warning: 'udsl_print_packet' declared `static' but never defined The rest seems fine. Thanks for looking at this. Roman. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
