-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Oliver! I'm quite open to your suggestions,
but I'd like to know the reasoning behind..
> + bytes_read +=
> + snprintf (dev->bulk_in_buffer, dev->bulk_in_size, "%s", HEADER);
> Use a copy operation.
What kind of copy, memcpy()? And just for simplicity?
> + while (bytes_read < IMGSIZE) {
> + result = usb_bulk_msg (dev->udev,
> You should make this interruptible.
How would this be done? And why do you think so?
> + result = idmouse_create_image (dev);
> Why on open()?
Because it's the simplest solution, IMHO. That way, you can just use
"cat" to get a fingerprint and don't have to know about any IOCTLs,
just open the device, read the data and close it again.
Yours, Florian
- --
Homo homini lupus.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFB48iy7CzyshGvatgRAnm5AKDTc2fae6FkS1YknXEG8SOd9EnsJgCdETL8
wo2rfexIL6Toml76rgOoBmk=
=5N8D
-----END PGP SIGNATURE-----
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
