On Wed, 12 Jan 2005, Jan De Luyck wrote: > > > The Genesys increased delay in this patch causes strange issues, the USB > > > disconnects after a while... > > > > > > I rewrote the identifier like it was previous this patch > > > > > > -- > > > if (us->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS && > > > -- > > > > > > and it works like I expected it to... > > > > I don't understand. That line of code wasn't changed by the patch. The > > patch only changed a comment and changed udelay(100) to udelay(110). > > If you check the 2.6.11-rc1 patch, you'll see that that line is changed too. > It's wrapped around with something.. can't check right now.
Ah, you must be talking about the le16_to_cpu() addition. That wasn't part of the increased-delay patch; it was in a separate changeset. The line now reads: if (le16_to_cpu(us->pusb_dev->descriptor.idVendor) == USB_VENDOR_ID_GENESYS) The le16_to_cpu() part _is_ necessary. The value it's looking at, the descriptor.idVendor, used to be stored in native byte order but now is stored in little-endian order. If you're using an x86 system, of course, there won't be any difference. Alan Stern ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
