On Thu, Feb 03, 2005 at 10:56:05AM -0500, Alan Stern wrote: > > Now there's a proposal to make this be a module parameter rather than a > config option, so that it can be changed on-the-fly via sysfs without > having to rebuild usb-storage.
That's a good thing. > The bad aspect of doing this is that it > would also eliminate the nice explanatory help message in the Kconfig > file, so the background information wouldn't be so easily available to > users any more. Use MODULE_PARAM_DESC() if you really care about this. > Suggested actions are: > > Move the explanation into the FAQ on www.linux-usb.org (a good > idea in any case). Not least of the advantages is that it would > then be findable by Google. Good idea. > Change the setting to a module parameter, and _keep_ the config > option -- but make the config option control only the initial > default value of the parameter. Then after a few more kernel > releases get rid of the config option entirely. (This feels > like overkill, albeit only temporary.) No, no config option. Like was stated, distros and users hate these (I already hate the usb-storage debug config option...) > Go ahead and do the complete changeover now (or as soon as the > FAQ is updated). I like this. > Leave the setting as a config option and don't add the parameter. No. > P.S.: This raises the issue of documenting a bunch of module parameters > added to the USB subsystem fairly recently. What's the best way to do > this? Add entries to Documentation/kernel-parameters.txt? Yes. as module paramaters, if the code is built into the kernel, they become kernel paramaters at boot time. Also use MODULE_PARAM_DESC. thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
