On Wed, Feb 16, 2005 at 12:33:34AM +0100, Jeroen Vreeken wrote:
> +
> +#define host2zd16(n) (__cpu_to_le16((__u16)(n)))
> +#define host2zd32(n) (__cpu_to_le32((__u32)(n)))
> +#define zd2host16(n) (__le16_to_cpu((__u16)(n)))
> +#define zd2host32(n) (__le32_to_cpu((__u32)(n)))

The usage of these macros is spitting out a _lot_ of warnings from
sparse when you run it with the -Wbitwise option.  Why have your own
macros?  Just use the cpu_to_le16 and friends in your code, it makes it
easier for everyone to understand what you are doing.

And when you do that, care to fix up those warnings?

thanks,

greg k-h


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to