On Fri, Feb 18, 2005 at 09:35:25PM +0100, Jeroen Vreeken wrote: > Oliver Neukum wrote: > > >+ urb->status = 0; > >+ urb->dev = zd->usb; > >+ if(usb_submit_urb(urb, GFP_ATOMIC)) > >+ free = 1; > > > >Aren't you missing a wake_up in the error case? > > > >+ unsigned int gfp_mask = wait ? GFP_KERNEL : GFP_ATOMIC; > > > >GFP_NOIO please. You might run nfs over the link. > > > > > Thanks, fixed them...
Thanks for making these changes, it looks good. I've applied it to my trees, and it will show up in the next -mm release and be sent to Linus after 2.6.11 is out. thanks, greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
