On Tue, 8 Mar 2005, Nishanth Aravamudan wrote:

> I was trying to keep to the current code as closely as possible, sorry.
> It loops at 10 jiffy intervals up to 50 times, which is a total of 500
> jiffies. If the intent was to use milliseconds, though, then
> interruptible_sleep_on_timeout() was a much more broken usage than I
> thought. Trust me, if I thought milliseconds should be used, I would
> have used them :)

I don't know what the original intent was, but it sure looks like 500 
milliseconds.  Shucks, the code might be old enough that it's supposed to 
be 5 seconds instead.  No way to know without asking the author.

Yes, this driver isn't in great shape.  That's why I asked if there was a
maintainer.

> I have no means of testing this device or my patches, though. And, to be
> frank, don't care too much about the device beyond a general feeling of
> making Linux better :)

I often feel the same way.  See how much trouble you get into when you try 
to improve a stale driver, even just a little bit?  :-)

Alan Stern



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to