Hi,
On Tue, 08 Mar 2005 11:55:47 -0500, Nick Sillik <[EMAIL PROTECTED]> wrote:
> +struct usb_onetouch_wrap {
> + struct list_head list;
> + struct usb_onetouch *onetouch;
> +};
I may be wrong but I thought USB connect routines could run
simultaneously if devices are on different hubs. If so then this list
should be protected.
> + /* Attempt to connect the onetouch urb to the device */
> + /* Note: If the CONFIG_USB_STORAGE_ONETOUCH is not set */
> + /* onetouch_connect_input(us) will always return 0 */
> + switch (onetouch_connect_input(us)) {
> + case 0:
> + break;
> + default:
> + printk(KERN_WARNING USB_STORAGE
> + "Unable to allocate onetouch urb\n");
> + }
> +
Does it really need to be a switch?
--
Dmitry
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
