Hi Dave,
Am Dienstag 22 M�rz 2005 09:49 schrieb David Brownell:
> Hi Karsten,
>
> I had a chance to look a bit more closely at all your split ISO patches, and
> they look good with the following exception:
>
> On Sunday 20 March 2005 4:06 am, Karsten Wiese wrote:
> > Without Hunk 1 ehci sitd's "Buffer Pointer (Page 1)" initialisation is
> > wrong,
>
> This still doesn't seem quite right. In fact "buf1" initialization in
> sitd_sched_init() looks seriously borked. I don't see how resizing to
> u32 could help ... the relevant field in the sITD is five bits, not 16!
handling of those five lsbits "TRANSACTION POSITION" & "TRANSACTION COUNT" (you
mean those?)
isn't touched by the u16 to u32 change.
its bits [31:12] where u32 instead of u16 really helps.
with u16, bits [31:16] of packet->buf1 don't exist physically, thusly compiler
must think they are 0.
so we only set dma address correctly with u32 in sitd_patch()'s line:
sitd->hw_buf [1] = cpu_to_le32 (uf->buf1);
> And sitd_patch() does the wrong stuff too.
>
> So what I'll do is post a revised patch merging all your split ISO fixes,
> with sitd_sched_init() and sitd_patch() updated to handle sitd->hw_buf[1]
> better ... and not just growing this field to 32 bits.
looking forward to check the right stuff out.
thanks!
Karsten
>
> - Dave
>
> > --- linux-2.6.11.2was/drivers/usb/host_ehci/ehci.h������2005-03-09
> > 09:12:44.000000000 +0100
> > +++ linux-2.6.11.2/drivers/usb/host/ehci.h������2005-03-19
> > 15:41:12.000000000 +0100
> > @@ -430,7 +430,7 @@
> > ��������__le32������������������transaction;����/* itd->hw_transaction[i]
> > |= */
> > ��������u8����������������������cross;����������/* buf crosses pages */
> > ��������/* for full speed OUT splits */
> > -�������u16���������������������buf1;
> > +�������u32���������������������buf1;
> > �};
> > �
> > �/* temporary schedule data for packets from iso urbs (both speeds)
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
