I'll comment on the unusual_devs part since that's my area....

Nicholas Sillik wrote:
--- linux-2.6.12-rc1-mm1/drivers/usb/storage/unusual_devs.h     2005-03-22 
18:27:55.000000000 -0500
+++ linux-2.6.12-rc1-mm1-onetouch/drivers/usb/storage/unusual_devs.h    
2005-03-22 20:09:12.000000000 -0500
@@ -161,7 +161,7 @@
                "FinePix 1400Zoom",
                US_SC_UFI, US_PR_DEVICE, NULL, US_FL_FIX_INQUIRY | 
US_FL_SINGLE_LUN),

-/* Reported by Peter Wächtler <[EMAIL PROTECTED]>
+/* Reported by Peter Wächtler <[EMAIL PROTECTED]>

Um how did that get there? I suspect that isn't supposed to be there.

  * The device needs the flags only.
  */
 UNUSUAL_DEV(  0x04ce, 0x0002, 0x0074, 0x0074,
@@ -991,3 +991,16 @@
                US_SC_SCSI, US_PR_SDDR55, NULL,
                US_FL_SINGLE_LUN),
 #endif
+
+/* Submitted by: Nick Sillik <[EMAIL PROTECTED]>
+ * Needed for OneTouch extension to usb-storage
+ *
+ */
+#ifdef CONFIG_USB_STORAGE_ONETOUCH
+       UNUSUAL_DEV(  0x0d49, 0x7010, 0x0000, 0x9999,
+                       "Maxtor",
+                       "OneTouch External Harddrive",
+                       US_SC_DEVICE, US_PR_DEVICE, onetouch_connect_input,
+                       0),
+#endif
+

I haven't made any attempt to apply this patch yet, but I get the feeling this isn't in order. Make sure it's in order my VendorId and then ProductId.

Next... do you really need the entire range of bcdDevice numbers? If you
suspect it's more than 1 or 2, it's fine to use the whole range, but if
it's a single device, or even a pair of devices, I'd rather you specify
the device number (it's the rev= part in /proc/bus/usb/devices).

--
Phil Dibowitz                             [EMAIL PROTECTED]
Freeware and Technical Pages              Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety."
 - Benjamin Franklin, 1759


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to