On Mon, 21 Mar 2005, Nick Sillik wrote: > I made all of the changes you (Alan, Matt, Greg) talked about.
No you didn't. You still #include <linux/config.h>, <linux/input.h>, and "usb.h" from within onetouch.h. It's not necessary to do that because those files are already #included by the source files that #include "onetouch.h". Also, your onetouch_release_input routine is wrong. The argument it receives is the ss->extra value, not ss itself. This gives you your onetouch pointer directly; there's no longer any need to search through the onetouch_list to find it or to test the descriptor values. (And there's no need for the "return" statement at the end of the routine.) So you don't need onetouch_list any more, which means you can also get rid of the last two fields in struct usb_onetouch, plus the spinlock. See how much simpler things can become when you use the right mechanism? > I'll send you the > code to make sure > I got everything. > > And here is what I've added to unusual_devs.h: > > #ifdef CONFIG_USB_STORAGE_ONETOUCH > UNUSUAL_DEV( 0x0d49, 0x7010, 0x0000, 0x9999, > "Maxtor", > "OneTouch External Harddrive", > US_SC_DEVICE, US_PR_DEVICE, onetouch_connect_input, > 0), > #endif That looks good. Alan Stern ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
