On Fri, Apr 08, 2005 at 02:49:13PM -0700, Greg KH wrote: > On Thu, Mar 31, 2005 at 07:40:46PM +0400, Roman Kagan wrote: > > On Wed, Mar 30, 2005 at 01:47:55PM -0800, Greg KH wrote: > > > ChangeSet 1.2181.4.57, 2005/03/24 14:34:40-08:00, [EMAIL PROTECTED] > > > > > > [PATCH] drivers/usb/core/usb.c: add MODALIAS env var to hotplug > > > > > > The patch below adds MODALIAS environment variable to usb hotplug > > > callout, allowing for its straightforward use with modprobe. > > > > > > Signed-off-by: Roman Kagan <[EMAIL PROTECTED]> > > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > Any chance to get my other patch re. modifying the module alias patterns > > in usb modules to correctly handle bcdDevice ranges included? I'm a bit > > worried about this one included without that one, because it's sort of > > encouraging the interface which used to be broken. > > In thinking about it a lot, I don't want to accept that change. I don't > think it is wise to break userspace tools in such a bad way. Especially > as I don't see a need for this (no one ever relied on matching based on > the bcdDevice range before, and if they did, the kernel handled it > properly internally anyway.)
I disagree with both your arguments :) 1) I'm unaware of any existing userspace tool which would be broken by that, exactly because it was practically impossible to create one; 2) now that MODALIAS is generated by the kernel, it will be the kernel which will be broken: for a number of drivers _no_ MODALIAS will match the MODULE_ALIAS_TABLE, and the userspace will have little to do about it. So, at the very least, if you think that bcdDevice range matching should be dropped from the module alias matching logic and only remain in the driver matching logic of the usb core, file2alias has to be changed to ignore bcdDevice in the driver and always put dl*dh*. I can write a patch for that but I'd like to know of at least one real-world compatibilty issue which would arise from my original patch. Thanks and cheers, Roman. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
