On Fri, Apr 29, 2005 at 05:48:16PM +0530, [EMAIL PROTECTED] wrote: > > > Hello Greg , > My code does tries to follow coding conventions. I have referred the > CodingStyle doc.The file I sent was a txt file enough to view some > important portions of the code. > > I am not sure what you meant by not following coding conventions.
Let's start with the most basic rules that you did not follow: - Did not use tabs instead of spaces - Did not put the braces in the correct places Fix those, and then move on to the other issues that the coding style document referrs to. You _will_ have to fix these issues eventually, so you might as well do them now, as no one will review your code if you have not done so. thanks, greg k-h ------------------------------------------------------- SF.Net email is sponsored by: Tell us your software development plans! Take this survey and enter to win a one-year sub to SourceForge.net Plus IDC's 2005 look-ahead and a copy of this survey Click here to start! http://www.idcswdc.com/cgi-bin/survey?id=105hix _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel