On Wed, 1 Jun 2005, David Brownell wrote:
On Wednesday 01 June 2005 7:12 pm, [EMAIL PROTECTED] wrote:
On Wed, 1 Jun 2005, David Brownell wrote:
And in fact, the real issue looks to be that it's only comparing ONE of the
GUIDs, not both ... :(
Try tweaking "usbnet.c" near line 2768 ... change one to "safe_guid",
they shouldn't both be "blan_guid". Yeech!
I changed the second blan_guid to safe_guid and that made it work!
Is that the right thing to do?
Yes. If you want Fame and Fortune, whip up a real "patch -p1" patch and
submit it ... :)
- Dave
:-)
I read Documentation/SubmittingPatches and came up with the attached pach
file.
It's against the 2.6.12-rc5 tree. Is posting it here sufficient?
--
[EMAIL PROTECTED]
gerry
--- linux-2.6.12-rc5/drivers/usb/net/usbnet.c.orig 2005-06-01
18:06:20.000000000 -0500
+++ linux-2.6.12-rc5/drivers/usb/net/usbnet.c 2005-06-01 18:29:30.000000000
-0500
@@ -2765,7 +2765,7 @@ static int blan_mdlm_bind (struct usbnet
}
/* expect bcdVersion 1.0, ignore */
if (memcmp(&desc->bGUID, blan_guid, 16)
- && memcmp(&desc->bGUID, blan_guid, 16) ) {
+ && memcmp(&desc->bGUID, safe_guid, 16) ) {
/* hey, this one might _really_ be MDLM! */
dev_dbg (&intf->dev, "MDLM guid\n");
goto bad_desc;
