On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote: > Hi, > > I have had small discussion about the patch on LKML with Alexey Dobriyan. > So I have fixed the issues and sending the fixed patch. > It is attached and pasted at the end of the e-mail. I am not sure what > is the better way.
Please read Documentation/Submitting patches for how to do this properly. Your patch was linewrapped, and you didn't have a good changelog entry, and no Signed-off-by: line :( > --- linux-2.6.11.11/drivers/usb/media/stv680.c 2005-05-27 > 08:06:46.000000000 +0300 > +++ linux/drivers/usb/media/stv680.c 2005-06-03 13:27:04.000000000 +0300 > @@ -9,6 +9,9 @@ > * Endpoints (formerly known as AOX) se401 USB Camera Driver > * Copyright (c) 2000 Jeroen B. Vreeken ([EMAIL PROTECTED]) > * > + * Creative WebCam Go Mini Driver, modified by Kiril Jovchev > + * ([EMAIL PROTECTED]) > + * > * Still somewhat based on the Linux ov511 driver. > * > * This program is free software; you can redistribute it and/or modify it > @@ -56,6 +59,11 @@ > * to set to a non-supported size. This allowed > * gnomemeeting to work. > * Fixed proc entry removal bug. > + * > + * ver 0.26 Sep, 2004 (kjv) > + * Added support for Creative WebCam Go mini. > + * Camera is based on same chip. > + * Adding changelog comments to the driver itself is not a good idea. Please don't do it. thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
