On Wednesday 15 June 2005 7:12 pm, C Michael Sundius wrote:
>
> On Jun 15, 2005, at 4:57 PM, Pete Zaitcev wrote:
>
> > On Wed, 15 Jun 2005 16:06:08 -0700, C Michael Sundius
> > <[EMAIL PROTECTED]> wrote:
> >
> >> I have made a patch to the usbnet driver for the Centillium P300,
> >> P400, and A100 chip. [...]
> >
> > Looks reasonable, but formatting is really strange. Would you mind
> > looking at the resulting code in vi or with cat(1)?
>
> fixed .. sorry.. sheesh.. that was ugly
Good, but you still got it wrong inside the "if (headroom < 4) {...}". :)
Now ... "CONFIG_USB_CTLM" mks m thnk y frgt hw t s vwls. Spell it out?
And please put it in alphabetical order with the other minidrivers;
C-for-Centillium goes after C-for-CDC-Ethernet.
I see your driver_info specifies the endpoints explicitly rather than
letting them be autodetected; if it works without doing that, please
don't specify them. Likewise the driver_info doesn't have any hook
for specifying connect status; is "always connected" appropriate, or
is there some mechanism to report whether the (ADSL) link is hooked
up at the other end?
Plus, the Kconfig says it's only for the P300, doesn't mention others;
and it mentions a _board_ not a chip (family). That's unclear. Is
the model that products here will use your product IDs, or is that
primarily intended as a reference design? Please have the Kconfig
provide a more accurate description.
> > What is the ID in the packet for? VLAN? If so, it would be nice to
> > support.
> >
> again the id field is Centillium proprietary
>
> Btw.. I also have a patch for the 2.4 kernel as well.. is it resonable
> to put that in as well or has that stopped being updated?
Well, I don't update the 2.4 code any more but don't let that stop you.
That patch would go through Pete.
- Dave
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
