On Tuesday 12 July 2005 22:56, Greg KH wrote:
>  drivers/usb/input/keyspan_remote.c     |  633 ++++++++++++++++++++++++++

Greg, Michael, sparse asks whether cpu_to_le16() are missed.

$ cat -n drivers/usb/input/keyspan_remote.c | head -n 437 | tail -n 4
   434          /* See if the offered device matches what we can accept */
   435          if ((udev->descriptor.idVendor != USB_KEYSPAN_VENDOR_ID) ||
   436              (udev->descriptor.idProduct != USB_KEYSPAN_PRODUCT_UIA11) )
   437                  return -ENODEV;

$ make C=2 CHECK="sparse -Wbitwise" drivers/usb/input/keyspan_remote.o
  CHECK   drivers/usb/input/keyspan_remote.c
drivers/usb/input/keyspan_remote.c:435:33: warning: incompatible types for 
operation (!=)
drivers/usb/input/keyspan_remote.c:435:33:    left side has type restricted 
unsigned short [usertype] idVendor
drivers/usb/input/keyspan_remote.c:435:33:    right side has type int
drivers/usb/input/keyspan_remote.c:436:34: warning: incompatible types for 
operation (!=)
drivers/usb/input/keyspan_remote.c:436:34:    left side has type restricted 
unsigned short [usertype] idProduct
drivers/usb/input/keyspan_remote.c:436:34:    right side has type int


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to