On Thu, 6 Oct 2005, Pete Zaitcev wrote: > On Thu, 6 Oct 2005 20:31:54 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > > > > Is there a particular scenario which this patch fixes? > > > > Yes, at least in part. See kernel bug 4916. > > > If the problem is caused by the HID driver spamming the log and > > monopolizing the CPU when a disconnect occurs, the solution is to avoid > > logging so many messages and add a delay before resubmitting. Don't > > just treat any old error as a disconnect. > > I see. Well, this patch looks promising: > http://bugme.osdl.org/attachment.cgi?id=5809&action=view > > Why don't we go that route instead of dropping -84's altogether?
That's okay with me, except that the patch has never been tested more than a tiny little bit. And it's very naive, in that it only pays attention to the interrupt-IN transfers. It needs to be able to handle ongoing interrupt-OUT and control transfers as well: detecting errors and restarting them after a reset. It also wouldn't hurt to reduce the error count limit to something lower than 10 and to add a short (50-100 ms) delay at the start of the hid_reset routine. And the -EPERM check should be removed. If you or Vojtech can make that patch fully functional and verify that it works as intended, then I'm all in favor of applying it. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
