On Thu, Oct 06, 2005 at 06:12:07PM -0400, Alan Stern wrote: > On Thu, 6 Oct 2005, Greg KH wrote: > > > On Mon, Oct 03, 2005 at 04:36:29PM -0400, Alan Stern wrote: > > > > > > P.S.: I'm puzzled by the quirk_piix3_usb routine at the start of the > > > pci-quirks.c file. Doesn't that handle UHCI controllers? > > > > Yes, it does, for only a specific pci device. > > > > > Is there some reason to have a separate routine, or can > > > quirk_usb_handoff_uhci replace it? > > > > No, it should be separate, as it's only needed to be run on 2 different > > pci devices, not for all UHCI devices. > > What I mean is, does it need to run at all? Won't the usual UHCI quirk > routine also run for those two PCI devices, and won't it end up doing the > same thing as the piix3 routine?
It doesn't look like the same logic in both places, so I would tend to believe those two broken devices need that exact command. You can fish back through the changelog comments to try to find out who added the function and go ask them if you really want to try to remove this. good luck, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
