On Thu, Nov 10, 2005 at 10:04:09AM +0100, Oliver Neukum wrote: > > OK, I see. > urb->status != kaweth->status > There is no race of this kind, but you are right, due to usb_kill_urb() > working also while the callback is running kaweth->status is no longer > needed, but it doesn't do harm either.
You're absolutely right. We can remove kaweth->status as well. However, before we do that we should add in some code so that the driver doesn't log scary (but harmless) error messages on shutdown. In fact even now it is possible to get those printks from the resubmit function if usb_kill_urb() fails to kill it using unlink. I'll send you a patch for that tomorrow. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
