On Fri, Apr 21, 2006 at 03:51:06PM +0200, David Brownell wrote: > On Friday 21 April 2006 1:57 am, Jan Veldeman wrote: > > In some cases the irq may not be requested by usb_add_hcd. E.g. the > > interrupt is shared among different parts of the same driver, and by > > having only 1 handler which calls the others, helps in making the > > driver cleaner. > > > > By exporting usb_hcd_irq, the driver can call the irq handler at the > > correct time, without duplicating any code (otherwise, the > > functionality of ush_hcd_irq had to be duplicated). > > Sure, but zero is a perfectly valid IRQ number so you should > trigger this behavior on something better, like being negative. >
I thought about doing that (I even had the patch ready), but as it turns out there has been a recent discussion on which IRQ should denote NO_IRQ: http://article.gmane.org/gmane.linux.kernel/394303 If I recall correctly, Linus wants it to be 0 (although, like you say, it's a valid IRQ number). Best regards, Jan ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
