On Friday 21 April 2006 6:56 am, Jan Veldeman wrote: > On Fri, Apr 21, 2006 at 03:51:06PM +0200, David Brownell wrote:
> > Sure, but zero is a perfectly valid IRQ number so you should > > trigger this behavior on something better, like being negative. > > > > I thought about doing that (I even had the patch ready), but as it turns > out there has been a recent discussion on which IRQ should denote > NO_IRQ: Better URL for the whole discussion is: http://marc.theaimsgroup.com/?t=113253601200001&r=2&w=2 > If I recall correctly, Linus wants it to be 0 (although, like you say, > it's a valid IRQ number). That discussion circles around pci_dev->irq, which is not only "unsigned" (!) but has a certain history on x86 PCI registers. For PCI devices, hcd-pci does indeed make that check against zero. But this is USB, which is not PCI and is not x86-specific ... and that field has never had that interpretation or history. So there's no reason not to use a negative number there. - Dave ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
