[EMAIL PROTECTED] wrote: > > > Sorry, I wrote this email 3 days ago, but I used the wrong email address :(
No worries. But please use "reply-to-all" so the list is CC'd. > > I have a few concerns about your patch: > > > 1. What makes you think it needs US_FL_FIX_CAPACITY and > > US_FL_IGNORE_RESIDUE? > > US_FL_FIX_CAPACITY : It didn't work without it, BUT I have opened the disk > as "physical disc" > with Hex Workshop under win xp now, which says the last sector is 38997487 > and under linux > dmesg shows "SCSI device sda: 38997488 512-byte hdwr sectors (19967 MB)" > without patch. > So this would be ok. In that case the flag is needed. Sounds good to me. > US_FL_IGNORE_RESIDUE : I used usbsniff under windows to log the traffic and > see yourself <SNIP> OK, I'm happy with that. > > 2. You refer to three names for this device. Do they all use bcdDevice > > ID of 1.03 (i.e. 0x0103) like the one you showed: > > > > P: Vendor=0ed1 ProdID=7636 Rev= 1.03 > > > ? If so, can we limit your range from 0103-0103 instead of 0000-9999 > > like you've done? > > No Idea, because I have only an EasyLite DJ 20. So in fact, I could not even > say if > they have the same ProductID & VendorID, although it is probably for the > Easylite DJ20 > and the Typhoon DJ1820. But after googling again i'm not sure if TGE is also > a manufacturer > of this device or if the device only includes some units from TGE, because > TGE doesn't > provide this device on their site. So perhaps the patch should be You're mis understanding me - I don't care about the text for the vendor and product... those don't matter to the kernel. You're VendorId and ProductID numbers are right, but you're including 9,999 devices in your patch, when you only know one is broken. We should limit your patch to only the one device we know to be broken: 103. What happens if you try a patch that looks like: > --- unusual_devs.h 2006-04-04 19:24:11.915787000 +0200 > +++ ../../../../linux/drivers/usb/storage/unusual_devs.h 2006-04-04 > 19:27:51.085484250 +0200 > @@ -1143,10 +1143,17 @@ > "USB", > "Flash Disk", > US_SC_DEVICE, US_PR_DEVICE, NULL, > US_FL_IGNORE_RESIDUE ), > > +/* Reported by Benjamin Schiller <[EMAIL PROTECTED]> */ > +UNUSUAL_DEV( 0x0ed1, 0x7636, 0x0103, 0x0103, > + "Typhoon", > + "My DJ 1820", > + US_SC_DEVICE, US_PR_DEVICE, NULL, > + US_FL_IGNORE_RESIDUE | US_FL_GO_SLOW ), > + > /* Reported by Michael Stattmann <[EMAIL PROTECTED]> */ > UNUSUAL_DEV( 0x0fce, 0xd008, 0x0000, 0x0000, > "Sony Ericsson", > "V800-Vodafone 802", > US_SC_DEVICE, US_PR_DEVICE, NULL, > > instead? -- Phil Dibowitz [EMAIL PROTECTED] Freeware and Technical Pages Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Suess
signature.asc
Description: OpenPGP digital signature
