On Mon, May 22, 2006 at 10:53:40AM -0400, Alan Stern wrote: > On Mon, 22 May 2006, Franck Bui-Huu wrote: > > > and use completion timeout instead. > > > > Signed-off-by: Franck Bui-Huu <[EMAIL PROTECTED]> > > This looks okay to me, although you might as go ahead and use > wait_for_completion_interruptible_timeout so that the time spent waiting > will be properly accounted as I/O.
Definately.
Also, what is the value of MAX_SCHEDULE_TIMEOUT, and is it a sane value?
> Also you should get approval from Matt Dharm, the usb-storage maintainer.
Other than the above change and comment, it looks good to me.
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
A female who groks UNIX? My universe is collapsing.
-- Mike
User Friendly, 10/11/1998
pgpQYq927sFiM.pgp
Description: PGP signature
