On Mon, May 22, 2006 at 10:20:58AM -0700, Matthew Dharm wrote: > On Mon, May 22, 2006 at 10:53:40AM -0400, Alan Stern wrote: > > On Mon, 22 May 2006, Franck Bui-Huu wrote: > > > > > and use completion timeout instead. > > > > > > Signed-off-by: Franck Bui-Huu <[EMAIL PROTECTED]> > > > > This looks okay to me, although you might as go ahead and use > > wait_for_completion_interruptible_timeout so that the time spent waiting > > will be properly accounted as I/O. > > Definately. > > Also, what is the value of MAX_SCHEDULE_TIMEOUT, and is it a sane value?
Now that I think about it some more, why use MAX_SCHEDULE_TIMEOUT at all?
You're imposing a timeout where none existed before...
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
It was a new hope.
-- Dust Puppy
User Friendly, 12/25/1998
pgpy7da4pgJrl.pgp
Description: PGP signature
