On Tue, 13 Jun 2006, David Brownell wrote: > I'll hold back on comments about some of these till later, > but several of them look good.
It's good to get feedback, especially when so much of it is positive! > > 1. Change the disconnect checking in devio.c (the usbfs code) so > > that it will detect cases where the device has been unregistered > > from usbfs, even if the device is still connected. Although this > > can't happen now, it will be able to occur after patch 4. > > The usbfs model is still problematic, but fixing it will take time. > Especially given a need to let applications keep working! This patch won't help to fix the usbfs model. It's a pretty minimal change. > > 2. Fix usb-skeleton so that it won't try to submit URBs after its > > disconnect method has returned. It's quite likely that there > > are drivers based on usb-skeleton in need of the same fix, but > > I don't know which ones they are. > > I remember discussions on that topic a few years back ... a few > drivers got fixed, evidently not this significant one. I guess I > have a hard time taking any driver seriously that doesn't have > even a mutex to synchronize threads which may be concurrently > issuing calls like read(), write(), disconnect(), and suspend(). Maybe now you'll be able to take usb-skeleton seriously. :-) > > 3. Move some driver-related code from usb.c to driver.c. These > > routines (concerned with uevent generation and claiming/releasing > > interfaces as well as suspend/resume handling) should have gone > > into driver.c when it was first split off, but they got left > > behind somehow. > > So Documentation/DocBook/usb.tmpl needs an update too, right? To > include all these functions. You can even add things like section > headers to better explain how the parts of those APIs fit together. Shucks, usb.tmpl has been out-of-date for ages. The changes in this patch series don't make it significantly more out-of-date than it was. Rewriting the documentation will just have to wait until later... Alan Stern _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
