On Tue, 13 Jun 2006, David Brownell wrote: > On Monday 12 June 2006 12:19 pm, Alan Stern wrote: > > Greg: > > > > This patch (as717) gets rid of the recursion we've always had in the > > suspend and resume routines. Now suspending a hub won't automatically > > suspend all the child devices first, and resuming a hub won't > > automatically resume all the child devices afterward. > > Erm, the suspend-path recursion was removed most of a year ago... > agreed that the matching resume path updates didn't merge at tha > time, and fixes there are needed.
I goofed in the patch description. Yes, it gets rid of the resume-path recursion only. > Did you test this with remote wakeup on all three HCDs? And with plain > old external hubs? With and without CONFIG_USB_SUSPEND? I suppose I > was just a bit surprised to see how much resume-side recursion could > be removed and have things still work. So I'm curious about just how > much is known to work. ;) I've done some testing, there hasn't been enough time to be really thorough about it. (This was an example of "Post early, post often" philosophy.) It works with EHCI and UHCI and external hubs, when CONFIG_USB_SUSPEND is set. I haven't tried it yet with CONFIG_USB_SUSPEND unset -- in fact, I haven't yet tried any of this stuff with a system suspend. > As for testing all this, I guess I'm suspecting that being able to > do it in a couple groups might be good. And patch seven-of-nine > is a bout where I start wanting to do very separate tests. :) I don't see much point testing this patch without also including the patch (719) that ties together the devices and interfaces. Although everything should work without that later patch applied, I didn't intend the changes to stop short of all nine patches. Alan Stern _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
