On Wednesday 12 July 2006 1:08 am, [EMAIL PROTECTED] wrote:
>
> Dear all.
>
> I encountered this crash by our insert/eject tests several times
> with Asianux v2(2.6.9-34.21AXsmp).
> I think that this crash is the same pattern reported at
> http://sourceforge.net/mailarchive/message.php?msg_id=10654542.
> Looking into dump file, the urb->hcpriv was nulled.
> The patch avoiding this crash for 2.6.17.4 is as follows.
That should WARN_ON(1) instead of just continuing; that's one of
those "should never happen" bugs. When you paper over such bugs
you should (a) put a comment saying that's what you're doing,
and usually (b) put in some kind of runtime diagnostic so that
information starts coming in about when (and eventually why!)
the bug triggers.
Because the fix everyone's interested in is the one to the
bug this is working around...
- Dave
>
>
> Signed-off-by:Takamasa Ohtake <[EMAIL PROTECTED]>
>
> Index: linux-2.6.17.4/drivers/usb/host/ohci-q.c
> ===============================================================================
> diff -uprN -X dontdiff linux-2.6.17.4.org/drivers/usb/host/ohci-q.c
> linux-2.6.17.4/drivers/usb/host/ohci-q.c
> --- linux-2.6.17.4.org/drivers/usb/host/ohci-q.c 2006-07-07
> 05:02:28.000000000 +0900
> +++ linux-2.6.17.4/drivers/usb/host/ohci-q.c 2006-07-12 15:08:26.000000000
> +0900
> @@ -985,6 +985,8 @@ rescan_this:
>
> /* HC may have partly processed this TD */
> td_done (ohci, urb, td);
> + if ( urb_priv == NULL )
> + continue;
> urb_priv->td_cnt++;
>
> /* if URB is done, clean up */
> ^---
>
> Oops: 0000 [#1]
> SMP
> Modules linked in: aic7xxx ses hasipmi hasftctl ohci_hcd md5 ipv6 i2c_dev
> i2c_core ide_dump scsi_dump diskdump zlib_deflate gemini_dump dm_mirror
> dm_multipath dm_mod butt
> on battery ac sr_mod usb_storage joydev hw_random shpchp e1000 lpfc
> scsi_transport_fc ext3 jbd raid1 aic79xx sd_mod had_mod scsi_mod acpiphp
> geminifb
> CPU: 1
> EIP: 0060:[<f8c48af1>] Tainted: PF VLI
> EFLAGS: 00010046 (2.6.9-34.21AXsmp)
> EIP is at finish_unlinks+0x10b/0x221 [ohci_hcd]
> eax: 00000002 ebx: d9f32080 ecx: d9f320b4 edx: 00000000
> esi: 00000000 edi: de0b7080 ebp: de2f8180 esp: f7f51dc0
> ds: 007b es: 007b ss: 0068
> Process kacpid (pid: 15, threadinfo=f7f51000 task=f7f42cb0)
> Stack: c2346680 de0b7088 00000000 00000000 d9f32074 de2f8198 00000000 00000000
> de0b7080 de2f8180 00000000 000003e8 f8c490e3 00000246 f7e80380 f8c49089
> ffffff8d c2346684 00000000 c025a440 de2f8408 f7e80380 00000000 e0022000
>
> Call Trace:
> [<f8c490e3>] ohci_endpoint_disable+0x5a/0x146 [ohci_hcd]
> [<f8c49089>] ohci_endpoint_disable+0x0/0x146 [ohci_hcd]
> [<c025a440>] hcd_endpoint_disable+0x177/0x17f
> [<c025b6df>] usb_disable_endpoint+0x1e/0x3d
> [<c025b746>] usb_disable_device+0x15/0xc5
> [<c0257699>] usb_disconnect+0xc4/0x130
> [<c0257687>] usb_disconnect+0xb2/0x130
> [<c025d9eb>] usb_hcd_pci_remove+0x70/0x12e
> [<c01c963f>] pci_device_remove+0x16/0x28
> [<c021fa94>] device_release_driver+0x3c/0x46
> [<c021fc77>] bus_remove_device+0x5d/0x97
> [<c021ef6f>] device_del+0x6f/0x90
> [<c021ef98>] device_unregister+0x8/0x10
> [<c01c78f2>] pci_destroy_dev+0x10/0x6d
> [<f88315c0>] acpiphp_unconfigure_function+0x11/0x5a [acpiphp]
> [<f8830563>] disable_device+0x46/0x8f [acpiphp]
> [<f88309ee>] acpiphp_disable_slot+0x30/0x9f [acpiphp]
> [<f8830660>] acpiphp_check_bridge+0x2a/0x92 [acpiphp]
> [<f8830744>] handle_hotplug_event_bridge+0x7c/0x108 [acpiphp]
> [<c01ee7cf>] acpi_ut_release_mutex+0x69/0x6c
> [<c01f10bb>] acpi_bus_check_device+0x3d/0x5f
> [<c01f10f5>] acpi_bus_check_scope+0x18/0x1e
> [<c01f1122>] acpi_bus_notify+0x27/0x36
> [<c01de31f>] acpi_ev_notify_dispatch+0x52/0x5b
> [<c01da0f8>] acpi_os_execute_deferred+0xc/0x16
> [<c0131143>] worker_thread+0x168/0x1d5
> [<c01da0ec>] acpi_os_execute_deferred+0x0/0x16
> [<c011ecf0>] default_wake_function+0x0/0xc
> [<c011ecf0>] default_wake_function+0x0/0xc
> [<c0130fdb>] worker_thread+0x0/0x1d5
> [<c01346ed>] kthread+0x73/0x9b
> [<c013467a>] kthread+0x0/0x9b
> [<c01041f5>] kernel_thread_helper+0x5/0xb
> Code: 04 24 83 78 2c 8d 75 09 83 c3 08 89 5c 24 04 eb 47 8b 54 24 04 89 d9 8b
> 02 83 e0 1f 0b 43 08 89 02 8b 14 24 89 e8 e8 ce fc ff ff <0f> b7 46 06 40 66
> 39 46 04 66 89
> 46 06 75 1e c7 44 24 0c 01 00
>
>
> crash> struct urb c2346680
> struct urb {
> kref = {
> refcount = {
> counter = 1
> }
> },
> lock = {
> lock = 1,
> magic = 3735899821
> },
> hcpriv = 0x0,
> urb_list = {
> next = 0xc2346690,
> prev = 0xc2346690
> },
> bandwidth = 0,
> use_count = {
> counter = 0
> },
> reject = 0 '\0',
> dev = 0xe0022000,
> pipe = 2147484672,
> status = -108,
> transfer_flags = 24,
> transfer_buffer = 0x0,
> transfer_dma = 507093760,
> transfer_buffer_length = 0,
> actual_length = 0,
> setup_packet = 0xe1c88060 "!?",
> setup_dma = 566788192,
> start_frame = 0,
> number_of_packets = 0,
> interval = 0,
> error_count = 0,
> context = 0xf6e56e90,
> complete = 0xf8c4ea04,
> iso_frame_desc = 0xc23466ec
> }
>
>
> --------------------------------------------------
> Takamasa Ohtake | Servers Software Division
> | NEC System Technologies, Ltd.
> | [EMAIL PROTECTED]
> --------------------------------------------------
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> linux-usb-devel@lists.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
