On Fri, Aug 04, 2006 at 02:23:52PM +0000, Luiz Fernando N. Capitulino wrote:
> +/*
> + * usb_endpoint_dir_in - check whether the endpoint has IN direction
> + * @epd: endpoint to be checked
> + *
> + * Returns positive if the endpoint has IN direction, and zero else
> + */
Wrong kernel doc style, you need to have a "/**" on the first line for
it to work properly. Build the documentation to verify that it picks it
up properly.
Also, please use a real sentence for the description.
> +/*
> + * usb_endpoint_xfer_bulk - check whether the endpoint has bulk transfer type
> + * @epd: endpoint to be checked
> + *
> + * Returns positive if the endpoint has bulk transfer type, and zero else
> + */
> +int usb_endpoint_xfer_bulk(struct usb_endpoint_descriptor *epd)
> +{
> + return ((epd->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
> USB_ENDPOINT_XFER_BULK);
> +}
Keep things within 80 columns please.
> +EXPORT_SYMBOL(usb_endpoint_dir_in);
> +EXPORT_SYMBOL(usb_endpoint_dir_out);
> +EXPORT_SYMBOL(usb_endpoint_xfer_bulk);
> +EXPORT_SYMBOL(usb_endpoint_xfer_int);
> +EXPORT_SYMBOL(usb_endpoint_xfer_isoc);
> +EXPORT_SYMBOL(usb_endpoint_is_bulk_in);
> +EXPORT_SYMBOL(usb_endpoint_is_bulk_out);
> +EXPORT_SYMBOL(usb_endpoint_is_int_in);
> +EXPORT_SYMBOL(usb_endpoint_is_int_out);
> +EXPORT_SYMBOL(usb_endpoint_is_isoc_in);
> +EXPORT_SYMBOL(usb_endpoint_is_isoc_out);
EXPORT_SYMBOL_GPL please, that's what the USB core is moving toward.
thanks,
greg k-h
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
