Em Sun, 27 Aug 2006 12:50:17 -0700 Greg KH <[EMAIL PROTECTED]> escreveu:
| On Sat, Aug 26, 2006 at 11:53:06PM -0300, Luiz Fernando N. Capitulino wrote: | > | > Hi Greg, | > | > Do you have suggestions on how to make usb_serial_probe() smaller? | | Why? Because it's pretty big. It has 20 local variables (which four are arrays) and it has more than 300 lines (ok, not so fair because I've included spaces and comments, but it's big anyway). A good feature is that it's not hard to follow (considering the complex job it does). | > I tried some different approaches but ended up with a more complex code... | | Yeah, it's not the smallest function, but it does the complex things | that are currently needed to be done for usb-serial devices. Right. | If it's working, and can't be made simpler by refactoring, then I'd say | just leave it alone :) Okay, I'll keep trying then. :) -- Luiz Fernando N. Capitulino ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
