Sam Bishop wrote:
> On Wednesday 30 August 2006 3:40 am, Franck Bui-Huu wrote:
>> This patch also fixes a bug in usb_device_poll() at the same time.
>> Previous code always raised POLLIN bit although no event happened
>> on the bus.
> 
> I believe this is expected behavior.  I mentioned it in the patch I submitted 
> and no one complained, at least.  If you're taking the "compare" approach, 
> you could use that immediate-return behavior to "prime the pump" by 
> immediately storing the current contents so that you'll later have something 
> to compare against.
> 

Sorry I wasn't clear here. With the previous code, first call to
poll() always succeed if no event had occured since the file was
opened. With this patch, the first call to poll() blocks if no event
happened.  But I shouldn't call the old behaviour a bug.

More importantly, with this patch the BKL is not used anymore.

                Franck

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to