On Wed, 30 Aug 2006, David Brownell wrote: > > Oops, crossed lines. Greg, this patch isn't needed. One that you have > > already applied (as754) takes care of the problem. > > What's the name for that one in Greg's tree?
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-04-usb/usbcore-make-hcd_endpoint_disable-wait-for-queue-to-drain.patch There is one aspect of the patch that I don't like. The use of usb_kill_urb is efficient but racy. It's possible that between dropping the spinlock and calling usb_kill_urb, the URB might complete and be resubmitted for a different endpoint. Perhaps it would be better to replace the function call with a copy of the usb_kill_urb code; that way the racy part could remain inside the spinlock-protected region. Alan Stern ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
