This is a note to let you know that I've just added the patch titled Subject: USB: OHCI: remove stale testing code from root-hub resume
to my gregkh-2.6 tree. Its filename is usb-ohci-remove-stale-testing-code-from-root-hub-resume.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ >From [EMAIL PROTECTED] Fri Oct 27 07:35:11 2006 Date: Fri, 27 Oct 2006 10:35:01 -0400 (EDT) From: Alan Stern <[EMAIL PROTECTED]> To: Greg KH <[EMAIL PROTECTED]> cc: David Brownell <[EMAIL PROTECTED]>, USB development list <linux-usb-devel@lists.sourceforge.net> Subject: USB: OHCI: remove stale testing code from root-hub resume Message-ID: <[EMAIL PROTECTED]> This patch (as811) removes some stale testing code from the root-hub resume routine in ohci-hcd. It also adds a spin_lock_irq() call that inadvertently got left out of an error pathway. Signed-off-by: Alan Stern <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- drivers/usb/host/ohci-hub.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) --- gregkh-2.6.orig/drivers/usb/host/ohci-hub.c +++ gregkh-2.6/drivers/usb/host/ohci-hub.c @@ -204,18 +204,6 @@ __acquires(ohci->lock) goto skip_resume; spin_unlock_irq (&ohci->lock); - temp = ohci->num_ports; - while (temp--) { - u32 stat = ohci_readl (ohci, - &ohci->regs->roothub.portstatus [temp]); - - /* force global, not selective, resume */ - if (!(stat & RH_PS_PSS)) - continue; - ohci_writel (ohci, RH_PS_POCI, - &ohci->regs->roothub.portstatus [temp]); - } - /* Some controllers (lucent erratum) need extra-long delays */ msleep (20 /* usb 11.5.1.10 */ + 12 /* 32 msec counter */ + 1); @@ -223,6 +211,7 @@ __acquires(ohci->lock) temp &= OHCI_CTRL_HCFS; if (temp != OHCI_USB_RESUME) { ohci_err (ohci, "controller won't resume\n"); + spin_lock_irq(&ohci->lock); return -EBUSY; } Patches currently in gregkh-2.6 which might be from [EMAIL PROTECTED] are usb/ehci-hcd-fix-budget_pool-allocation-for-machines-with-multiple-ehci-controllers.patch usb/usb-core-don-t-match-interface-descriptors-for-vendor-specific-devices.patch usb/usb-hid-handle-stall-on-interrupt-endpoint.patch usb/usb-takes-31-devices-per-hub.patch usb/usb-hub-root-hub-code-takes-more-than-15-devices.patch usb/usb-ohci-disable-rhsc-inside-interrupt-handler.patch usb/usb-ohci-fix-root-hub-resume-bug.patch usb/usb-ohci-hcd-fix-compiler-warning.patch usb/usb-ohci-remove-stale-testing-code-from-root-hub-resume.patch g-usb-hub-autosuspend-autoresume.patch g-ehci-repair-remote-wakeup-support.patch ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel