On Sat, Nov 11, 2006 at 10:35:48PM -0800, David Brownell wrote:
> On Saturday 11 November 2006 8:06 am, Adrian Bunk wrote:
> > The Coverity checker spotted the following NULL dereference of "skb" in
> > drivers/usb/gadget/ether.c:
>
> I don't see such a dereference. As usual, free(NULL) is legit.
>...
void dev_kfree_skb_any(struct sk_buff *skb)
{
if (in_irq() || irqs_disabled())
dev_kfree_skb_irq(skb);
else
dev_kfree_skb(skb);
}
And the first thing dev_kfree_skb_irq() does is to dereference skb...
> > <-- snip -->
> >
> > ...
> > static int
> > rx_submit (struct eth_dev *dev, struct usb_request *req, gfp_t gfp_flags)
> > {
> > struct sk_buff *skb;
> > int retval = -ENOMEM;
> > ...
> > if ((skb = alloc_skb (size + NET_IP_ALIGN, gfp_flags)) == 0) {
> > DEBUG (dev, "no rx skb\n");
> > goto enomem;
> > }
> > ...
> > enomem:
> > defer_kevent (dev, WORK_RX_MEMORY);
> > if (retval) {
> > DEBUG (dev, "rx submit --> %d\n", retval);
> > dev_kfree_skb_any (skb);
> > ...
> >
> > <-- snip -->
> >
> > cu
> > Adrian
> >
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
