On Sat, Nov 11, 2006 at 11:10:17PM -0800, David Brownell wrote:
>
> >
> > void dev_kfree_skb_any(struct sk_buff *skb)
> > {
> > if (in_irq() || irqs_disabled())
> > dev_kfree_skb_irq(skb);
> > else
> > dev_kfree_skb(skb);
> > }
> >
> >
> > And the first thing dev_kfree_skb_irq() does is to dereference skb...
>
> Yet dev_kfree_skb() --> kfree_skb() starts with the standard idiom
>
> if (unlikely(!skb))
> return
>
> Seems to me that the finger of blame is more appropriately pointed
> at either dev_kfree_skb_any() or dev_kfree_skb_irq() ...
>...
Adding the net maintainers to the Cc:
Is there any reason why dev_kfree_skb_irq() has no NULL check for "skb"?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
