On Wednesday 06 December 2006 8:04 pm, Geoff Levand wrote:
> Fix ohci-hcd quirk in the Cell processor's south bridge 'spider'.
> 
> Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
> 
> ---
> 
> I'm not entirely certain this is the proper place to put
> this, but it does make the controller work.  Comments
> welcome.

I don't see anything to _set_ this flag on any system.  Is this
a PCI device?  Feel free to send me a PS3 to test with.  ;)

If it's a PCI device, I'd rather see it merge with a patch that
I will be resending, which will help make PCI quirks easier to
manage than just augmenting a big if/else tree.

- Dave


> -Geoff
> 
>  drivers/usb/host/ohci-hcd.c |    7 +++++++
>  drivers/usb/host/ohci.h     |    1 +
>  2 files changed, 8 insertions(+)
> 
> --- cell--common--7.orig/drivers/usb/host/ohci-hcd.c
> +++ cell--common--7/drivers/usb/host/ohci-hcd.c
> @@ -662,6 +662,12 @@ retry:
>               temp |= RH_A_NOCP;
>               temp &= ~(RH_A_POTPGT | RH_A_NPS);
>               ohci_writel (ohci, temp, &ohci->regs->roothub.a);
> +     } else if (ohci->flags & OHCI_QUIRK_SPIDER) {
> +             /* South Bridge for Cell */
> +             temp = RH_A_PSM | RH_A_OCPM;
> +             ohci_writel (ohci, temp, &ohci->regs->roothub.a);
> +             temp = 0x0060000;
> +             ohci_writel (ohci, temp, &ohci->regs->roothub.b);
>       } else if ((ohci->flags & OHCI_QUIRK_AMD756) || distrust_firmware) {
>               /* hub power always on; required for AMD-756 and some
>                * Mac platforms.  ganged overcurrent reporting, if any.
> --- cell--common--7.orig/drivers/usb/host/ohci.h
> +++ cell--common--7/drivers/usb/host/ohci.h
> @@ -396,6 +396,7 @@ struct ohci_hcd {
>  #define      OHCI_QUIRK_INITRESET    0x04                    /* SiS, OPTi, 
> ... */
>  #define      OHCI_BIG_ENDIAN         0x08                    /* big endian 
> HC */
>  #define      OHCI_QUIRK_ZFMICRO      0x10                    /* Compaq 
> ZFMicro chipset*/
> +#define      OHCI_QUIRK_SPIDER       0x20                    /* South Bridge 
> for Cell (spider) */
>       // there are also chip quirks/bugs in init logic
>  
>  };
> 
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> linux-usb-devel@lists.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to