Hi Dave, The problem I was faced with was getting such things as the OHCI register layout info, and the solution I came up with was using the existing header file. It would certainly be better if the definitions pertaining to the OHCI controller were in a seperate header file and could be included by all the different drivers that require it. Such a patch would affect the existing driver for PCI based OHCI controllers as well ELAN's U132/FTDI based OHCI controller driver.
Would it be OK for me to submit a patch to the existing OCHI driver to separate out a header-file? Thanks for you input to this issue, best regards Tony Olech ---------------------------------------------------------------------- As you surmised the reason for including the header was to get On Wed, 2007-01-03 at 19:54 -0800, David Brownell wrote: > On Wednesday 03 January 2007 5:53 pm, Benjamin Herrenschmidt wrote: > > On Wed, 2007-01-03 at 17:03 -0800, Andrew Morton wrote: > > > On Thu, 14 Dec 2006 14:13:28 +1100 > > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > > > This patch separates support for big endian MMIO register access > > > > and big endian descriptors in order to support the Toshiba SCC > > > > implementation which has big endian registers but little endian > > > > in-memory descriptors. > > > > > > > > It simplifies the access functions a bit in ohci.h while at it. > > > > > > For reasons which aren't immediately apparent, this patch causes: > > > > > > drivers/usb/misc/ftdi-elan.c:2307:1: warning: "OHCI_QUIRK_ZFMICRO" > > > redefined > > > In file included from drivers/usb/misc/ftdi-elan.c:76: > > > drivers/usb/misc/../host/ohci.h:399:1: warning: this is the location of > > > the previous definition > > > > > > One site defines it as 0x10 and the other as 0x20. > > > > > > Something's screwed up. > > > > After a second look and a big urge to go vomit I'd say the ftdi thingy > > is screwed up. > > Yeah, it really shouldn't be grotting around in the internals of the > OHCI driver like that. *AND* it badly needs "Lindent" run on it. > > Tony, you're maintaining the ftdi-elan driver ... can you come up with > a patch to make it not use internals of a different driver? > > To the extent that all it needs is OHCI register layout info, I'd > suggest creating a <linux/usb/ohci-regs.h> header. I expect there > will be something similar for EHCI coming along (because of needing > to access the debug port), and that's where things like that belong. > > - Dave > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
